1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
<% if @favorite_flag %> <div class="float-l-r" > <%=link_to_remote image_tag('blue-star-howto.jpg'), :update => "rating", :url => { :controller => "howto", :action => "delete_favorite",:id => @howtoguide.id }%> </div> <% else %> <div class="float-l-r" > <%= link_to_remote image_tag('blank_star_image.jpg'), :update => "rating", :url => { :controller => "howto", :action => "update_favorite",:id => @howtoguide.id }%> </div> <% end%>
Refactorings
No refactoring yet !
Apirak Panatkool
August 21, 2008, August 21, 2008 15:08, permalink
1 rating.
Login to rate!
1 2 3 4 5 6 7 8 9
<% @link = @favorite_flag ? ["blue-star-howto.jpg", "delete_favorite"] : [ "blank_star_image.jpg", "update_favorite"] %> <div class="float-l-r" > <%=link_to_remote image_tag(@link[0]), :update => "rating", :url => { :controller => "howto", :action => @link[1], :id => @howtoguide.id }%> </div>
Apirak Panatkool
August 21, 2008, August 21, 2008 15:13, permalink
1 rating.
Login to rate!
do it simple way
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
<% if @favorite_flag @image = "blue-star-howto.jpg" @action = "delete_favorite" else @image = "blank_star_image.jpg" @action = "update_favorite" end %> <div class="float-l-r" > <%=link_to_remote image_tag(@image), :update => "rating", :url => { :controller => "howto", :action => @action, :id => @howtoguide.id }%> </div>
Hi,
- In following code snippet maximum code is getting repeat only image name & action name are changing as per the value of @favorite_flag.
Thanks
DG